Skip to content

Dismiss all stale Github reviews#3382

Merged
marco-c merged 4 commits into
mozilla:masterfrom
La0:github-never-approves
May 26, 2026
Merged

Dismiss all stale Github reviews#3382
marco-c merged 4 commits into
mozilla:masterfrom
La0:github-never-approves

Conversation

@La0
Copy link
Copy Markdown
Collaborator

@La0 La0 commented May 22, 2026

This PR dismisses all previous reviews made by the bot, then only publishes a new review if some issues have been detected.

When no issue is found, nothing is published.

Site note: the current github app cannot load its own user information to identify itself (probably a scope missing), so I had to hardcode the bot's login in order to only dismiss its own reviews.

@La0 La0 requested review from Archaeopteryx and marco-c May 22, 2026 09:24
@La0 La0 self-assigned this May 22, 2026
Comment thread bot/code_review_bot/report/github.py Outdated
Comment thread bot/code_review_bot/report/github.py
@La0
Copy link
Copy Markdown
Collaborator Author

La0 commented May 25, 2026

I updated the code to publish an "issue" comment, which is in fact a comment on the pull request in that context.

@La0 La0 requested a review from marco-c May 25, 2026 15:21
Comment thread bot/code_review_bot/report/github.py
Comment thread bot/code_review_bot/sources/github.py
marco-c
marco-c previously approved these changes May 25, 2026
@La0 La0 requested a review from marco-c May 26, 2026 08:50
@marco-c marco-c merged commit ed85312 into mozilla:master May 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants